Switch docker env from ct_server to TesseraCT#2210
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
===========================================
- Coverage 57.93% 44.95% -12.98%
===========================================
Files 50 72 +22
Lines 3119 4689 +1570
===========================================
+ Hits 1807 2108 +301
- Misses 1154 2344 +1190
- Partials 158 237 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This looks great!
I realized, quite surprisingly, we don't have an e2e test in this repo that uses a non-mocked CT log. Could we throw together a minimal one, something like spinning up the containers, making a request using either https://github.com/sigstore-conformance/extremely-dangerous-public-oidc-beacon/ or a fake OIDC provider, and verifying the certificate and its SCT?
| - ctStorage:/ctfe:z | ||
| - ./config/ctfe/:/etc/ctfe:ro | ||
| - ./config/fulcio-root:/etc/fulcio:ro | ||
| user: root |
There was a problem hiding this comment.
nit, is this needed, I thought root was the default user?
There was a problem hiding this comment.
For some reason I needed it when I switched to the ko scaffolding image, maybe ko is non-root by default.
|
I added #2230 to demonstrate working E2E tests with no changes , then based this PR on that commit. |
Hayden-IO
left a comment
There was a problem hiding this comment.
Looks great, thanks for adding the tests! Just needs a rebase
Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Relates to sigstore/rekor-tiles#73
Summary
Release Note
Documentation