Skip to content

Add extension for deployment environment#2190

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:environment
Nov 4, 2025
Merged

Add extension for deployment environment#2190
Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:environment

Conversation

@Hayden-IO

Copy link
Copy Markdown
Contributor

This defines a new OID for a "deployment environment". By itself, it's not very meaningful as it's a user-defined string, but this can be used by a monitor to validate artifact provenance, e.g. verifying that a deployment environment had certain protections enabled.

Fixes #1845

Summary

Release Note

Documentation

This defines a new OID for a "deployment environment". By itself, it's
not very meaningful as it's a user-defined string, but this can be used
by a monitor to validate artifact provenance, e.g. verifying that a
deployment environment had certain protections enabled.

Fixes sigstore#1845

Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
@Hayden-IO Hayden-IO requested a review from a team as a code owner October 29, 2025 23:42
@Hayden-IO

Copy link
Copy Markdown
Contributor Author

cc @di @woodruffw

@Hayden-IO

Copy link
Copy Markdown
Contributor Author

also cc @kommendorkapten

@Hayden-IO Hayden-IO requested a review from bobcallaway October 29, 2025 23:44
@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.62%. Comparing base (cf238ac) to head (d298de1).
⚠️ Report is 493 commits behind head on main.

Files with missing lines Patch % Lines
pkg/certificate/extensions.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2190       +/-   ##
===========================================
- Coverage   57.93%   44.62%   -13.32%     
===========================================
  Files          50       72       +22     
  Lines        3119     4668     +1549     
===========================================
+ Hits         1807     2083      +276     
- Misses       1154     2349     +1195     
- Partials      158      236       +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kommendorkapten kommendorkapten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @haydentherapper!

@di di left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hayden-IO Hayden-IO merged commit 4a86d8b into sigstore:main Nov 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fulcio certs: Encode the CI/CD "environment" in an extension?

4 participants