feat: adds cert loading and key-match validation.#2173
Merged
Hayden-IO merged 6 commits intoOct 15, 2025
Merged
Conversation
b784a1a to
f2ae54e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
===========================================
- Coverage 57.93% 44.16% -13.78%
===========================================
Files 50 72 +22
Lines 3119 5788 +2669
===========================================
+ Hits 1807 2556 +749
- Misses 1154 2998 +1844
- Partials 158 234 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a5fb906 to
3831204
Compare
e2f6d27 to
1994b56
Compare
Hayden-IO
reviewed
Oct 13, 2025
Contributor
Author
|
@haydentherapper cheers / thanks for the quick fb, ready for another 👀. thanks again / 🙇 |
152fd4e to
c6e8b4c
Compare
Hayden-IO
previously approved these changes
Oct 14, 2025
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
…s tests, and docs. Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
…/aws creds). Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
… flags, refactored certificate loading to use cryptoutils and kept test error semantics in pkg/certmaker/cert_loader.go, and updatd interface{} to any.
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
13187c7 to
de2a8aa
Compare
Hayden-IO
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2070
summary
adds support for reusing existing root/intermediate certs when issuing new leaf certs with the certmaker tool.
includes cli flags (
--existing-root-cert,--existing-intermediate-cert), validation, and updated docs.all kms providers supported (aws, gcp, azure, vault).
release note
--existing-root-certand--existing-intermediate-certflags.documentation
docs updated under
docs/certificate-maker.mdwith new examples, decision tree, and troubleshooting notes.