Skip to content

expose gcp kms retry and timeout options#2132

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
bobcallaway:kms_retries
Aug 18, 2025
Merged

expose gcp kms retry and timeout options#2132
Hayden-IO merged 1 commit into
sigstore:mainfrom
bobcallaway:kms_retries

Conversation

@bobcallaway

Copy link
Copy Markdown
Member

now that these are exposed in sigstore/sigstore, we can take advantage of them.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from a team as code owners August 18, 2025 16:45
@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.50%. Comparing base (cf238ac) to head (691123d).
⚠️ Report is 450 commits behind head on main.

Files with missing lines Patch % Lines
cmd/app/serve.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2132       +/-   ##
===========================================
- Coverage   57.93%   43.50%   -14.43%     
===========================================
  Files          50       71       +21     
  Lines        3119     5661     +2542     
===========================================
+ Hits         1807     2463      +656     
- Misses       1154     2972     +1818     
- Partials      158      226       +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hayden-IO Hayden-IO enabled auto-merge (squash) August 18, 2025 16:49
@Hayden-IO Hayden-IO merged commit 89f7f6b into sigstore:main Aug 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants