Skip to content

fix(config): respect cacert on oidc-issuers#2098

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
hown3d:cacert-issuer
Jul 25, 2025
Merged

fix(config): respect cacert on oidc-issuers#2098
Hayden-IO merged 1 commit into
sigstore:mainfrom
hown3d:cacert-issuer

Conversation

@hown3d

@hown3d hown3d commented Jul 12, 2025

Copy link
Copy Markdown
Contributor

Closes #2097

Summary

Respect the ca-cert field in the prepare method when creating oidc providers.

Release Note

fix(config): respect cacert on oidc-issuers

Documentation

Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
@hown3d hown3d requested a review from a team as a code owner July 12, 2025 17:22

@Hayden-IO Hayden-IO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@Hayden-IO Hayden-IO enabled auto-merge (squash) July 25, 2025 02:50
@codecov

codecov Bot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.32%. Comparing base (cf238ac) to head (197d5b9).
Report is 433 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/config.go 55.55% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2098       +/-   ##
===========================================
- Coverage   57.93%   43.32%   -14.62%     
===========================================
  Files          50       72       +22     
  Lines        3119     5676     +2557     
===========================================
+ Hits         1807     2459      +652     
- Misses       1154     2991     +1837     
- Partials      158      226       +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hayden-IO Hayden-IO merged commit 07b0302 into sigstore:main Jul 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CACert field on oidc-issuers is not respected

2 participants