Do not HTML-escape extension values#2023
Merged
Merged
Conversation
This fixes a bug report where extensions contained HTML-escaped characters, e.g. < rather than <. The root cause and the fix is simple: instead of using html/template, we should use text/template which does not escape any characters. Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
===========================================
- Coverage 57.93% 43.55% -14.39%
===========================================
Files 50 73 +23
Lines 3119 5722 +2603
===========================================
+ Hits 1807 2492 +685
- Misses 1154 3001 +1847
- Partials 158 229 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Also LOL at the description, I typed |
bobcallaway
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug report where extensions contained HTML-escaped characters, e.g. < rather than <. The root cause and the fix is simple: instead of using html/template, we should use text/template which does not escape any characters.
Summary
Release Note
Documentation