Skip to content

Tls verification on OIDC issuers#1932

Merged
Hayden-IO merged 2 commits into
sigstore:mainfrom
Horiodino:TLS_verification_on_OIDC_Issuers
Mar 10, 2025
Merged

Tls verification on OIDC issuers#1932
Hayden-IO merged 2 commits into
sigstore:mainfrom
Horiodino:TLS_verification_on_OIDC_Issuers

Conversation

@Horiodino

Copy link
Copy Markdown
Contributor

Summary

implemented the functionality to pass the certificate as a parameter in PEM format.

fixes : #1665

Release Note

Documentation

Signed-off-by: Horiodino <holiodin@gmail.com>
@Horiodino

Copy link
Copy Markdown
Contributor Author

can anyone review this please ??

Comment thread pkg/config/config.go
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go
@Horiodino Horiodino force-pushed the TLS_verification_on_OIDC_Issuers branch from f2251bb to 9d5c148 Compare March 3, 2025 12:47
@Horiodino Horiodino requested review from a team as code owners March 3, 2025 12:47
@codecov

codecov Bot commented Mar 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.66%. Comparing base (cf238ac) to head (b631055).
Report is 309 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/config.go 46.87% 13 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1932       +/-   ##
===========================================
- Coverage   57.93%   43.66%   -14.28%     
===========================================
  Files          50       73       +23     
  Lines        3119     5714     +2595     
===========================================
+ Hits         1807     2495      +688     
- Misses       1154     2991     +1837     
- Partials      158      228       +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Horiodino <holiodin@gmail.com>

Use default transport if it is nil

Signed-off-by: Horiodino <holiodin@gmail.com>

check pool initialization in validateConfig

Signed-off-by: Horiodino <holiodin@gmail.com>

fixed failing ci

Signed-off-by: Horiodino <holiodin@gmail.com>
@Horiodino Horiodino force-pushed the TLS_verification_on_OIDC_Issuers branch from 9d5c148 to b631055 Compare March 3, 2025 12:55
@Horiodino Horiodino requested a review from Hayden-IO March 3, 2025 16:42
@Hayden-IO Hayden-IO merged commit c0e7131 into sigstore:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS verification on OIDC Issuers

2 participants