Skip to content

feat: makes leaf optional and other changes. #1931

Merged
Hayden-IO merged 6 commits into
sigstore:mainfrom
ianhundere:feat/makes-leaf-optional-etc
Feb 4, 2025
Merged

feat: makes leaf optional and other changes. #1931
Hayden-IO merged 6 commits into
sigstore:mainfrom
ianhundere:feat/makes-leaf-optional-etc

Conversation

@ianhundere

@ianhundere ianhundere commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

closes #1930

Summary

makes leaf optional as per @haydentherapper's request as well as updates docs etc.

Release Note

Documentation

Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
@codecov

codecov Bot commented Jan 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 39.50617% with 49 lines in your changes missing coverage. Please review.

Project coverage is 51.91%. Comparing base (cf238ac) to head (7dc0a20).
Report is 295 commits behind head on main.

Files with missing lines Patch % Lines
pkg/certmaker/certmaker.go 42.62% 29 Missing and 6 partials ⚠️
pkg/certmaker/template.go 0.00% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
- Coverage   57.93%   51.91%   -6.03%     
==========================================
  Files          50       73      +23     
  Lines        3119     5619    +2500     
==========================================
+ Hits         1807     2917    +1110     
- Misses       1154     2431    +1277     
- Partials      158      271     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianhundere ianhundere changed the title Feat/makes leaf optional etc feat: makes leaf optional and other changes. Jan 28, 2025
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
@ianhundere

Copy link
Copy Markdown
Contributor Author

this is ready for 👀

cc @haydentherapper

Comment thread pkg/certmaker/certmaker.go Outdated
Comment thread pkg/certmaker/certmaker.go Outdated
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>

@Hayden-IO Hayden-IO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the updates!

@Hayden-IO Hayden-IO merged commit 0859642 into sigstore:main Feb 4, 2025
@ianhundere ianhundere deleted the feat/makes-leaf-optional-etc branch February 4, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make leaf optional in certificate-maker

2 participants