Skip to content

Fix master failing test#915

Merged
AgeManning merged 2 commits intomasterfrom
correct-bls-test
Mar 17, 2020
Merged

Fix master failing test#915
AgeManning merged 2 commits intomasterfrom
correct-bls-test

Conversation

@AgeManning
Copy link
Member

Issue Addressed

Master currently fails if cargo update is applied. The mock BLS key used to test ssz encoding is not of the correct range. The new BLS throws a panic and the test fails.

This PR specifies a valid BLS key for the test.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Mar 16, 2020
@AgeManning
Copy link
Member Author

May want to remove the test_random function altogether and just use SecretKey::random()

@AgeManning AgeManning merged commit 756b110 into master Mar 17, 2020
@AgeManning AgeManning deleted the correct-bls-test branch April 14, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants