Check attestation shuffling when producing blocks#900
Merged
michaelsproul merged 6 commits intomasterfrom Apr 20, 2020
Merged
Conversation
9739b55 to
f8adb05
Compare
e6864a6 to
33ea2f7
Compare
paulhauner
approved these changes
Apr 19, 2020
Relying on the block root alone could have caused us to wrongly include an attestation from the current epoch if the root was initially checked against the previous epoch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #845
Proposed Changes
During block production, use the fork choice block DAG to check that the implied shuffling for an attestation is the same as the state on which the block is being produced. This ensures that the signature check that was done upon inserting into the op pool remains valid, and prevents attestations from forks with different shufflings from appearing on chain with seemingly invalid signatures.
Additional Info
To avoid having the op pool contain a reference to fork choice, the
get_attestationsfunction takes a filtering closure. I thought this was quite neat (and functional 😏)!TODO
attestation_shuffling_is_compatible