Merged
Conversation
…estations when num attestations < T::MaxAttestation
Contributor
Author
|
Props to @michaelsproul for guiding me (he did almost all the work...)! |
Member
|
Nice work!! Fast block production. Woop! |
michaelsproul
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
None
Proposed Changes
Additional Info
When I ran tests locally I found out that this should be something like 1000x improvement on block production (scaling with the number of attestations in the op_pool...). 💃
I would ask for the reviewer to make sure that disabling this verification will not cause any harm. I have checked twice for myself. The only place (that I'm aware of) where we call
op_pool.insert_attestationis here:lighthouse/beacon_node/beacon_chain/src/beacon_chain.rs
Lines 1084 to 1085 in 7396cd2
where we just verified that attestations had valid signatures
lighthouse/beacon_node/beacon_chain/src/beacon_chain.rs
Line 1048 in 7396cd2
I am pretty sure this should be safe but having someone else double check won't hurt.