Correct flakey CI tests #6646
Merged
Correct flakey CI tests #6646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Clippy is failing |
Member
|
Does the |
jimmygchen
approved these changes
Dec 10, 2024
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good to me. This should also fix the test @michaelsproul mentioned above.
150a750 to
a1c44a6
Compare
Member
|
Rebased on |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 3b8254a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Some subnet service tests were failing occasionally. There were two bugs that I found.
I've run these tests repeatedly without fail, so at the very least, should make these more stable.