Validator client refactor by paulhauner · Pull Request #618 · sigp/lighthouse

paulhauner · 2019-11-21T23:21:55Z

Issue Addressed

Resolves Onboarding testnet validators #604
Resolves Re-implement seperate threading for validator client duties #342
Resolves Validator client to request block production at specific slot #336

Proposed Changes

Modifies account_manager to suit the deposit flow in Onboarding testnet validators #604.
Refactors the validator client to be more use http and be more async.
Removes gRPC project-wide.
Adds a maximum skip slots of 128. Without this, it causes lots of problems with high validator counts and skip slots. HTTP requests start to pile up.
Adds a snazzy new github actions CI.

paulhauner

Self review

beacon_node/rest_api/src/lib.rs

beacon_node/eth2-libp2p/src/behaviour.rs

beacon_node/eth2-libp2p/src/discovery.rs

beacon_node/eth2-libp2p/src/service.rs

tests/node_test_rig/src/lib.rs

validator_client/src/attestation_service.rs

validator_client/src/config.rs

validator_client/src/lib.rs

validator_client/src/validator_directory.rs

michaelsproul

Looks good on the whole, just a few minor changes

beacon_node/beacon_chain/src/beacon_chain.rs

beacon_node/rest_api/Cargo.toml

beacon_node/rest_api/src/beacon.rs

beacon_node/rest_api/tests/test.rs

book/src/setup.md

eth2/utils/slot_clock/src/testing_slot_clock.rs

validator_client/src/validator_directory.rs

validator_client/src/duties_service.rs

paulhauner · 2019-11-25T04:12:17Z

All comments have been addressed!

michaelsproul

Happy to merge when CI passes!

Kimtrai2020 · 2022-01-13T17:11:08Z

Issue Addressed

Resolves Onboarding testnet validators #604

Resolves Re-implement seperate threading for validator client duties #342

Resolves Validator client to request block production at specific slot #336

Proposed Changes

Modifies account_manager to suit the deposit flow in Onboarding testnet validators #604.

Refactors the validator client to be more use http and be more async.

Removes gRPC project-wide.

Adds a maximum skip slots of 128. Without this, it causes lots of problems with high validator counts and skip slots. HTTP requests start to pile up.

Adds a snazzy new github actions CI.

michaelsproul and others added 30 commits November 11, 2019 15:00

Update to spec v0.9.0

aaa5f20

Update to v0.9.1

c36bb94

Bump spec tags for v0.9.1

c9bfe9c

Formatting, fix CI failures

d0249a5

Resolve accidental KeyPair merge conflict

2651255

Document new BeaconState functions

2ed8eca

Add validator changes from validator-to-rest

4180561

Add initial (failing) REST api tests

7b5a868

Fix signature parsing

7406ef8

Add more tests

a433ff8

Refactor http router

173f649

Add working tests for publish beacon block

501a255

Add validator duties tests

b0b2010

Move account_manager under lighthouse binary

cc7430d

Unify logfile handling in environment crate.

5a9298d

Fix incorrect cache drops in advance_caches

d9467a8

Update fork choice for v0.9.1

0eb24bb

Add deposit_contract crate

8561a95

Add progress on validator onboarding

c1b5418

Add unfinished attesation code

ad40c4a

Update account manager CLI

1e67663

Write eth1 data file as hex string

ad5fed7

Integrate ValidatorDirectory with validator_client

93afdac

Move ValidatorDirectory into validator_client

c5071af

Merge remote-tracking branch 'origin/master' into v0.9

70e0528

Clean up some FIXMEs

d05774d

Add beacon_chain_sim

90d63a4

Fix a few docs/logs

601951a

Expand beacon_chain_sim

40a0bd0

Fix spec for `beacon_chain_sim

444db02

paulhauner added 10 commits November 23, 2019 17:02

Tidy signing, reduce ForkService duplication

f76f97a

Fail if skipping too many slots

ef7b641

Set default recent genesis time to 0

3dfb2ff

Add custom http timeout to validator

ca46a30

Fix compile bug in node_test_rig

42f98f1

Remove old bootstrap flag from val CLI

46a3764

Update docs

f62deb7

Tidy val client

7991bbc

Change val client log levels

1271448

Add comments, more validity checks

811248d

paulhauner commented Nov 23, 2019

View reviewed changes

paulhauner added 6 commits November 23, 2019 21:34

Fix compile error, add comments

1c1d86b

Undo changes to eth2-libp2p/src

e94c265

Reduce duplication of keypair generation

0768161

Add more logging for validator duties

936577e

Fix beacon_chain_sim, nitpicks

24dc948

Fix compile error, minor nits

6bf73e2

paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 24, 2019

paulhauner marked this pull request as ready for review November 24, 2019 22:55

michaelsproul reviewed Nov 25, 2019

View reviewed changes

paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 25, 2019

Address Michael's comments

65cbf60

michaelsproul approved these changes Nov 25, 2019

View reviewed changes

paulhauner merged commit 78d82d9 into master Nov 25, 2019

paulhauner deleted the kill-grpc branch May 16, 2020 23:23

dapplion mentioned this pull request Jun 27, 2024

Drop skip too large condition for liveness safety #6014

Merged

Conversation

paulhauner commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed Changes

Uh oh!

paulhauner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulhauner commented Nov 25, 2019

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

Kimtrai2020 commented Jan 13, 2022

Issue Addressed

Proposed Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paulhauner commented Nov 21, 2019 •

edited

Loading