Skip to content

Implement Keystore spec for BLS12-381 secret keys#596

Closed
pawanjay176 wants to merge 220 commits intosigp:masterfrom
pawanjay176:deposit-params
Closed

Implement Keystore spec for BLS12-381 secret keys#596
pawanjay176 wants to merge 220 commits intosigp:masterfrom
pawanjay176:deposit-params

Conversation

@pawanjay176
Copy link
Copy Markdown
Member

@pawanjay176 pawanjay176 commented Nov 6, 2019 •
edited
Loading

Proposed Changes

Implement the Keystore standard eip-2335 for BLS12-381 secret keys.

Account paths eip-2334 is not implemented as we don't have/need key-trees currently. Can add it in a future PR.

Todo

  • Decide on folder structure for storing keys.

@pawanjay176
Initial commit. web3 api working.
07488a9
@pawanjay176
Tidied up lib. Add function for fetching logs.
27a5efc
@pawanjay176
Refactor with Eth1DataFetcher trait
6f56fa3
@pawanjay176
Add parsing for deposit contract logs and get_eth1_data function
63f40b0
@pawanjay176
Add get_eth1_votes function
2d82b88
@pawanjay176
Refactor to cache Eth1Data
e290b6e
@pawanjay176
Fix merge conflicts and minor refactorings
2664f82
@pawanjay176
Rename Eth1Cache to Eth1DataCache
df63d1e
@pawanjay176
Refactor events subscription
01b6c02
@pawanjay176
Add deposits module to interface with BeaconChain deposits
8850419
@pawanjay176
Remove utils
0e0bf01
@pawanjay176
Rename to types.rs and add trait constraints to Eth1DataFetcher
e7c5a4f
@pawanjay176
Confirm to trait constraints. Make Web3DataFetcher cloneable
b2a1050
@pawanjay176
Make fetcher object member of deposit and eth1_data cache and other f…
557a929 
…ixes

* Fix update_cache function
* Move fetch_eth1_data to impl block
* Fix deposit tests
@pawanjay176
Create Eth1 object for interfacing with Beacon chain
3bdfe9a 
* Add `run` function for running update_cache and subscribe_deposit_logs tasks
* Add logging
@pawanjay176
Run cargo fmt and make tests pass
757eaf5
@pawanjay176
Convert sync functions to async
7417d97
@pawanjay176
Add timeouts to web3 functions
d471059
@pawanjay176
Return futures from cache functions
1164294
@pawanjay176
Add failed chaining of futures
e960f5b
@pawanjay176
Working cache updation
16738fa
@pawanjay176
Clean up tests and update_cache function
b297db9
@pawanjay176
Refactor get_eth1_data functions to work with future returning func…
02d8b78 
…tions
@pawanjay176
Refactor eth1 run function to work with modified update_cache api
db59dcd
@pawanjay176
Minor changes
9ca34b0
@pawanjay176
Add distance parameter to update_cache
37c92b0
@pawanjay176
Fix tests and other minor fixes
5367347
@pawanjay176
Working integration with cache and deposits
d74601b
@pawanjay176
Add merkle_tree construction, proof generation and verification code
f68c39a
@pawanjay176
Add function to construct and fetch Deposits for BeaconNode
845b496
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Nov 8, 2019
@pawanjay176
Copy link
Copy Markdown
Member Author

pawanjay176 commented Nov 8, 2019 •
edited
Loading

Folder structure used currently:

.lighthouse/
  - validators/
    - <uuid>/
      - "voting"-<UTC creation time>-<uuid>
      - "withdrawal"-<UTC creation time>-<uuid>
      - validator-history-<uuid>.sqlite
      - lockfile

Note: Voting and withdrawal keystores have the same uuid to ensure correspondence for later withdrawals.

@paulhauner paulhauner mentioned this pull request Nov 17, 2019
Closed
@pawanjay176 pawanjay176 changed the title [WIP] Implement Keystore spec for BLS12-381 secret keys Implement Keystore spec for BLS12-381 secret keys Nov 19, 2019
@pawanjay176 pawanjay176 changed the base branch from eth1 to master November 23, 2019 13:32
@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 25, 2019
@paulhauner
Copy link
Copy Markdown
Member

paulhauner commented Nov 26, 2019

Could you please merge in master when you get a chance? :)

@pawanjay176
Copy link
Copy Markdown
Member Author

pawanjay176 commented Nov 26, 2019

@paulhauner Merged master.

I'm not sure yet how to handle the Keystore in ValidatorDirectory.
One option is to add voting_keystore and withdrawal_keystore in the ValidatorDirectory struct as Option<Keystore> and convert the Keystore to a Keypair when required.

@paulhauner paulhauner added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 29, 2019
@paulhauner paulhauner self-assigned this Nov 29, 2019
@paulhauner paulhauner added this to the v0.2.0 milestone Dec 15, 2019
@AgeManning
Copy link
Copy Markdown
Member

AgeManning commented Jan 3, 2020

I'm working towards v0.2.0. I can take this over. Are we still blocked on deciding folder structure?
@paulhauner @pawanjay176

@pawanjay176
Copy link
Copy Markdown
Member Author

pawanjay176 commented Jan 3, 2020

Folder structure we have in the PR now is:

.lighthouse/
 - validators/
   - <uuid>/
     - "voting"-<UTC creation time>-<uuid>
     - "withdrawal"-<UTC creation time>-<uuid>
     - ...

The only difference in the folder structure compared to the testnet would be having the uuid as the folder name instead of the public key.

@pawanjay176 pawanjay176 mentioned this pull request Jan 7, 2020
Closed
@pawanjay176
Copy link
Copy Markdown
Member Author

pawanjay176 commented Jan 7, 2020 •
edited
Loading

@AgeManning created a new PR to maintain a clean commit history. This one got messed up with my old eth1 branch.

@paulhauner paulhauner mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulhauner paulhauner paulhauner left review comments

@AgeManning AgeManning Awaiting requested review from AgeManning

Assignees

@paulhauner paulhauner

Labels

ready-for-review The code is ready for review

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pawanjay176 @AgeManning @paulhauner