Enforce sync lookup receives a single result#5777
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom May 14, 2024
Merged
Conversation
realbigsean
approved these changes
May 14, 2024
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at ce66ab3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Current stable lookup requests include an internal request counter to differentiate requests. Because each lookup manages retries and streams it must handle interleaved packets from different requests.
PR removed the need for this internal counter, where network context handles streams and uniquely tags each request
However, a bug may break the invariant of 1 request at a time per lookup. If this happens, it will result in undefined behavior.
Proposed Changes
This change is quite strict but ensures that in the case of duplicate requests, we don't mix errors and results from other requests. The hard error is easy to pick up from metrics (in
sync_lookups_dropped_total{reason = "BadState"}) and logs.