Report RPC Errors to the application on peer disconnections#5658
Closed
AgeManning wants to merge 4 commits intosigp:unstablefrom
Closed
Report RPC Errors to the application on peer disconnections#5658AgeManning wants to merge 4 commits intosigp:unstablefrom
AgeManning wants to merge 4 commits intosigp:unstablefrom
Conversation
dapplion
approved these changes
Apr 29, 2024
Collaborator
dapplion
left a comment
There was a problem hiding this comment.
Thank you! expect usage is ok
pawanjay176
requested changes
May 1, 2024
| debug!(log, "Sender received a response"); | ||
| } | ||
| NetworkEvent::RPCFailed { id, peer_id, error } => { | ||
| panic!("got RPCError"); |
Member
There was a problem hiding this comment.
We should return true from the future if we entered this branch and only pass the test in that case.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are overhaling some internal RPC infrastructure, a desired feature is to report peer disconnects on RPC requests.
This PR should report an RPCError(Disconnected) if a connection is terminated whilst an RPC request is underway.