Skip to content

Add logging in UnknownBlockHashFromAttestation handling#5546

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
dapplion:should_search_for_block
Apr 10, 2024
Merged

Add logging in UnknownBlockHashFromAttestation handling#5546
mergify[bot] merged 2 commits intosigp:unstablefrom
dapplion:should_search_for_block

Conversation

@dapplion
Copy link
Collaborator

Issue Addressed

Continues

Proposed Changes

by adding the same style of logging to UnknownBlockHashFromAttestation:

  • One log for each received event
  • If event is ignored, log once why, reusing should_search_for_block

@dapplion dapplion requested a review from realbigsean April 10, 2024 03:13
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@realbigsean
Copy link
Member

@Mergifyio queue

@mergify
Copy link

mergify bot commented Apr 10, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 54fbdda

@realbigsean realbigsean added the ready-for-merge This PR is ready to merge. label Apr 10, 2024
@mergify mergify bot merged commit 54fbdda into sigp:unstable Apr 10, 2024
@dapplion dapplion deleted the should_search_for_block branch January 24, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants