Fix PublishBlockRequest SSZ decoding#5078
Merged
michaelsproul merged 3 commits intosigp:unstablefrom Jan 19, 2024
Merged
Conversation
85a9844 to
6c94be5
Compare
realbigsean
approved these changes
Jan 19, 2024
Member
realbigsean
left a comment
There was a problem hiding this comment.
Looks good! There's just a lint to fix, I think that's what's breaking CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix the SSZ decoder for the POST block endpoints (both v1 and v2). They were buggy due to interpreting the SSZ length at the start of the buffer as the slot. Credit to @realbigsean for the find.
Proposed Changes
Use the
ForkNamederived from the POST header. That's what it's there for 🤷♂️Additional Info
I've updated one of the tests to exercise the fork decoding more. Our existing tests that hit this codepath just happened to work because the misinterpreted slot matched the fork schedule 😱