Skip to content

Fix Rust 1.74. clippy and rustfmt errors#4931

Closed
jimmygchen wants to merge 2 commits intosigp:unstablefrom
jimmygchen:rust-1.74-lint
Closed

Fix Rust 1.74. clippy and rustfmt errors#4931
jimmygchen wants to merge 2 commits intosigp:unstablefrom
jimmygchen:rust-1.74-lint

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Nov 17, 2023

Issue Addressed

Fix lint error here:
https://github.com/sigp/lighthouse/actions/runs/6899736366/job/18771804765?pr=3954

Formatting error here:
https://github.com/sigp/lighthouse/actions/runs/6899976078/job/18772421594?pr=4931

There's a separate PR to fix new beta compiler warnings here: #4932

@jimmygchen jimmygchen added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Nov 17, 2023
@jimmygchen jimmygchen changed the title Fix Rust 1.74. clippy error Fix Rust 1.74. clippy and rustfmt error Nov 17, 2023
@jimmygchen jimmygchen changed the title Fix Rust 1.74. clippy and rustfmt error Fix Rust 1.74. clippy and rustfmt errors Nov 17, 2023
@jimmygchen
Copy link
Member Author

Closing in favour of #4932

@jimmygchen jimmygchen closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant