Closed
Conversation
da54f10 to
5ce971e
Compare
Member
Author
|
Closing this as the changes have been incorporated into #3711 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Continuation to #3711
Can be cherry picked into the above PR or can be merged after
Proposed Changes
UpgradeInfotrait onInboundRequest. This is likely a relic of an older libp2p version which we do not need anymore. Currently, we haveOutboundRequestContainerimplementingOutboundUpgradeandRPCProtocolimplementingInboundUpgradeto advertise the RPC protocols we support.enable_light_client_serverto network config instead of beacon config. @michaelsproul , sorry but I hadn't thought it out completely when you mentioned where to put the config 😅I feel putting it in the network config will be better because we can disable support for the protocols when we advertise it to our peers. Doing that will ensure that we don't receive any light client related network messages (rpc or gossip) into the beacon processor.
Additional info
@divagant-martian I removed the light client protocol support for
OutboundRequestbased on your comment here #3711 (comment)As I understand it, we do not need to advertise protocol support when creating outbound streams because we will not be making light client requests from the beacon node (server), so it's effectively an unreachable statement.