Skip to content

Ensure new health endpoint builds on MacOS#1215

Merged
paulhauner merged 6 commits intomasterfrom
mac-health
Jun 1, 2020
Merged

Ensure new health endpoint builds on MacOS#1215
paulhauner merged 6 commits intomasterfrom
mac-health

Conversation

@paulhauner
Copy link
Member

@paulhauner paulhauner commented May 28, 2020

Issue Addressed

Builds on MacOS are failing after #1197 was merged into master.

The last known good commit for MacOS is: 58a9f97

Proposed Changes

  • Adds release tests for MacOS to CI

TODO

  • Fix actual issue.

@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label May 28, 2020
@michaelsproul michaelsproul self-assigned this Jun 1, 2020
@michaelsproul michaelsproul marked this pull request as ready for review June 1, 2020 04:19
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jun 1, 2020
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to roll

@paulhauner paulhauner merged commit 723c7cb into master Jun 1, 2020
@paulhauner paulhauner deleted the mac-health branch June 1, 2020 11:18
@adaszko
Copy link
Contributor

adaszko commented Jun 1, 2020

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants