Scoring issue #5602
Description
Description
Seems there is an issue that Lighthouse incorrectly penalizes node that sends blobs via gossip later than Lighthouse gets it from RPC.
Version
5.1.3
Present Behaviour
Apr 18 06:19:27.073 DEBG Sending BlobsByRoot Request, lookup_type: Current, peer: 16Uiu2HAm67zXpZL32xYBTEptF6jfkykuinRJWeouLj9vMhPeX4zF, blob_indices: [0], block_root: 0x7e51083501c2beda888e93f0bb0038f0658cf469dc99593f5f807f1515618783, method: BlobsByRoot, service: sync, module: network::sync::network_context:490
Apr 18 06:19:27.268 DEBG Peer returned response for single lookup, response_type: Blob, block_root: 0x7e51083501c2beda888e93f0bb0038f0658cf469dc99593f5f807f1515618783, id: 2404, peer_id: 16Uiu2HAm67zXpZL32xYBTEptF6jfkykuinRJWeouLj9vMhPeX4zF, service: sync, module: network::sync::block_lookups:312
Apr 18 06:19:27.268 DEBG RPC blobs received, commitments: [0xad8d…38d4], slot: 1459897, block_root: 0x7e51…8783, indices: [0], module: network::network_beacon_processor::sync_methods:241
Apr 18 06:19:27.293 DEBG Simulated attestation evaluated, head_hit: true, target_hit: true, source_hit: true, attestation_slot: Slot(1459880), attestation_head: 0xa835baf1692cbf23b15dc59b6d6dc44ab20891bf2ccd5da3af15f46d2947351a, attestation_target: 0x55ebc094fb13bef949fdf7686b33435cc1c9e6c8e419badd14ffca8c67e2328a, attestation_source: 0x42e5943fc31651d5c6424fc26a5aaa0dc73ee6d7602d06ec17955958ba96667b, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:2050
Apr 18 06:19:27.303 DEBG Writing blobs to store, count: 3, block_root: 0x7e51…8783, service: beacon, module: beacon_chain::beacon_chain:3467
Apr 18 06:19:27.889 DEBG Successfully verified gossip blob, commitment: 0xad8d…38d4, index: 0, root: 0x7e51…8783, slot: 1459897, module: network::network_beacon_processor::gossip_methods:641
Apr 18 06:19:27.889 DEBG Invalid gossip blob, blob index: 0, block slot: 1459897, block root: 0x7e51083501c2beda888e93f0bb0038f0658cf469dc99593f5f807f1515618783, outcome: BlockIsAlreadyKnown(0x7e51083501c2beda888e93f0bb0038f0658cf469dc99593f5f807f1515618783), module: network::network_beacon_processor::gossip_methods:779
Apr 18 06:19:27.889 INFO gossip_penalize_peer, msg: bad_gossip_blob_ssz, action: Mid Tolerance Error, peer_id: 16Uiu2HAmP5fiuBbtmwDPjNeR9rSjfkZCwT7oiybcWXeE7xBa2Nvx, module: network::network_beacon_processor::gossip_methods:159
Apr 18 06:19:27.889 DEBG Peer score adjusted, score: inf, peer_id: 16Uiu2HAmP5fiuBbtmwDPjNeR9rSjfkZCwT7oiybcWXeE7xBa2Nvx, msg: bad_gossip_blob_ssz, service: libp2p, module: lighthouse_network::peer_manager::peerdb:530
Expected Behaviour
Should not penalize in such case.
Steps to resolve
I reproduced it by connecting Grandine with Lighthouse using --trusted-peers, however it seems that other peers were penalised too in the same way, so this issue should be visible quite often.