Skip to content

Validator client first_success swallows intermediate errors #3985

@michaelsproul

Description

@michaelsproul

Description

In the validator client's first_success function, errors are collected as different endpoints are tried. If several endpoints are tried before one that succeeds, the details of those errors will be lost when the function returns early here:

Ok(val) => return Ok(val),

In the logs from #3963 it seems like an offline primary BN caused delays when proposing via the secondary BN, possibly due to timeouts & errors at this stage.

It would be good to have logs (at least at debug! level) of errors as they occur in this function. However, this may be (partially) obsoleted by @macladson's improvements for #3613.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions