-
Notifications
You must be signed in to change notification settings - Fork 980
Closed
Description
Description
While experimenting with test_logger I found that when capturing the log output using std::process::Commands that slogger v1.0.2 the logs were sent to stdout. But with slogger v2.0.2 the logs are sent to stderr. It would be beneficial if only one version of slogger be used in lighthouse:
$ rg '"sloggers ' -g Cargo.lock
Cargo.lock
487: "sloggers 1.0.1",
676: "sloggers 1.0.1",
919: "sloggers 1.0.1",
1634: "sloggers 1.0.1",
1673: "sloggers 1.0.1",
3714: "sloggers 1.0.1",
4156: "sloggers 1.0.1",
5697: "sloggers 2.0.2",
6086: "sloggers 1.0.1",
The reason is that slasher/Cargo.toml specifies sloggers = "*" and the rest of Cargo.toml are specifying "1.0.1":
$ rg 'sloggers' -g Cargo.toml
boot_node/Cargo.toml
15:sloggers = "1.0.1"
slasher/Cargo.toml
24:sloggers = "*"
lighthouse/Cargo.toml
24:sloggers = "1.0.1"
lighthouse/environment/Cargo.toml
10:sloggers = "1.0.1"
beacon_node/network/Cargo.toml
8:sloggers = "1.0.1"
beacon_node/beacon_chain/Cargo.toml
34:sloggers = "1.0.1"
beacon_node/store/Cargo.toml
27:sloggers = "1.0.1"
beacon_node/eth1/Cargo.toml
11:sloggers = "1.0.1"
beacon_node/client/Cargo.toml
8:sloggers = "1.0.1"
Version
wink@3900x:~/prgs/ethereum/myrepos/lighthouse (unstable)
$ git log -1
commit 8d2650f (HEAD -> unstable, upstream/unstable, origin/unstable)
Author: Wink Saville wink@saville.com
Date: Tue Sep 7 23:56:59 2021 +0000
Make local-testnet setup more discoverable (#2572)
Move the contents of book/src/local-testnets.md into book/src/setup.md
to make it more discoverable.
Also, the link to scripts/local_testnet was missing `/local_testnet`.
Steps to resolve
Change so all crates to use the lastest version of slogger, v2.0.2.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels