Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: signalfx/golib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.41
Choose a base ref
...
head repository: signalfx/golib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.42
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 10, 2021

  1. Updated config.yml

    @jgheewala
    jgheewala committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    0110f04 View commit details
    Browse the repository at this point in the history

  2. sfxclient: http sink upon error should sha request headers that contain 

    secure credentials

some headers in the request can potentially contain secure credentials.
Added api loggableHeaders() which will extract out such headers that
should not be logged sha them and write it back.
    jgheewala committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    dcaed6c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #229 from signalfx/do_not_log_secure_headers 

    sfxclient: http sink upon error should not log all request headers
    @jgheewala
    jgheewala authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    b2adab8 View commit details
    Browse the repository at this point in the history
Loading