Skip to content

fix(types): improve ExecuteValues "nested" params#4133

Merged
wellwelwel merged 3 commits intosidorares:masterfrom
wellwelwel:execute
Feb 26, 2026
Merged

fix(types): improve ExecuteValues "nested" params#4133
wellwelwel merged 3 commits intosidorares:masterfrom
wellwelwel:execute

Conversation

@wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Feb 26, 2026

For reference:

function isJSON(value) {
return (
Array.isArray(value) ||
value.constructor === Object ||
(typeof value.toJSON === 'function' && !Buffer.isBuffer(value))
);
}

if (Object.prototype.toString.call(value) === '[object Date]') {
type = Types.DATETIME;
length = 12;
writer = function (value) {
// eslint-disable-next-line no-invalid-this
return Packet.prototype.writeDate.call(this, value, timezone);
};


  • [OFF] Interesting, the benchmark has no permission to comment on Pull Requests coming from forks.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (bde9aec) to head (e56ac7e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4133      +/-   ##
==========================================
+ Coverage   90.21%   90.23%   +0.01%     
==========================================
  Files          86       86              
  Lines       13740    13740              
  Branches     1662     1664       +2     
==========================================
+ Hits        12396    12398       +2     
+ Misses       1344     1342       -2     
Flag Coverage Δ
compression-0 89.46% <ø> (+0.01%) ⬆️
compression-1 90.21% <ø> (+0.01%) ⬆️
static-parser-0 87.83% <ø> (+0.01%) ⬆️
static-parser-1 88.58% <ø> (+0.01%) ⬆️
tls-0 89.64% <ø> (+0.01%) ⬆️
tls-1 90.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel marked this pull request as ready for review February 26, 2026 14:11
@wellwelwel wellwelwel changed the title refactor: improve ExecuteValues params fix: improve ExecuteValues "nested" params Feb 26, 2026
@wellwelwel wellwelwel changed the title fix: improve ExecuteValues "nested" params fix(types): improve ExecuteValues "nested" params Feb 26, 2026
@wellwelwel wellwelwel merged commit 3f94950 into sidorares:master Feb 26, 2026
88 checks passed
@wellwelwel wellwelwel deleted the execute branch February 26, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant