Skip to content

ci: fix benchmark#4120

Merged
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bench
Feb 24, 2026
Merged

ci: fix benchmark#4120
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bench

Conversation

@wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Feb 24, 2026

Tis PR ensures that the benchmark runs on the master branch. This makes benchmarks
executed in PRs compare directly against HEAD.

Also, the 150% margin for triggering an alert has a compounding degradation problem:

  1. If a benchmark detects 149%, it doesn't notify and the test passes normally.
  2. If the next benchmark also has a 149% loss, that loss is on top of the "new 100%", resulting in ~222% (1.49 × 1.49) accumulated performance loss between two distinct PRs, for example.

The margin was reduced to 110% (for now), limiting this silent drift.

@wellwelwel wellwelwel marked this pull request as ready for review February 24, 2026 18:24
@wellwelwel wellwelwel merged commit f9ac466 into sidorares:master Feb 24, 2026
86 checks passed
@wellwelwel wellwelwel deleted the bench branch February 24, 2026 18:25
@codecov

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant