Expose authPlugins to enable example from docs#1497
Merged
sidorares merged 1 commit intosidorares:masterfrom Nov 15, 2022
Merged
Expose authPlugins to enable example from docs#1497sidorares merged 1 commit intosidorares:masterfrom
sidorares merged 1 commit intosidorares:masterfrom
Conversation
Contributor
Author
|
Not sure why the Windows tests are failing on a date test. That should be unrelated to this PR? |
Owner
|
@MasterOdin definitely unrelated, I saw that started to happening in other PRs. Need to investigate that |
Owner
|
@MasterOdin could you rebase please? I have accidentally merged code in the master that fails linter but that should be fixed now |
Signed-off-by: Matthew Peveler <matt@popsql.com>
31a0137 to
fb0f911
Compare
Contributor
Author
|
@sidorares I've rebased the PR onto the latest master. |
Owner
|
I don't believe perf issue is real, nothing in the PR can contribute to it. Likely a slower CI runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example of using
authPluginsgiven in https://github.com/sidorares/node-mysql2/blob/master/lib/auth_plugins/caching_sha2_password.md is not possible, as this module does not expose a top levelauthPluginobject. This PR adds that top-level object, as well as fully typing for the existing plugins.