fix: The removeIdleTimeoutConnectionsTimer did not clean up when the … (#2384)

foxling · web-flow · commit 18a44f6a0a0b · 2024-01-18T18:35:39.000+11:00
* fix: The removeIdleTimeoutConnectionsTimer did not clean up when the pool was closed.

* test: when the pool is closed, it should clean up timers.
diff --git a/lib/pool.js b/lib/pool.js
@@ -100,6 +100,7 @@ class Pool extends EventEmitter {
 
   end(cb) {
     this._closed = true;
+    clearTimeout(this._removeIdleTimeoutConnectionsTimer);
     if (typeof cb !== 'function') {
       cb = function(err) {
         if (err) {
diff --git a/test/integration/test-pool-release-idle-connection.js b/test/integration/test-pool-release-idle-connection.js
@@ -38,7 +38,6 @@ pool.getConnection((err1, connection1) => {
           connection4.release();
           connection4.destroy();
           pool.end();
-          setTimeout(() => process.exit(0), 1000);
         });
       }, 7000);
     });
