Skip to content

chore: extract system+user volume config transformers, test#12196

Merged
talos-bot merged 1 commit intosiderolabs:mainfrom
laurazard:user-volumeconfig-internal-refactors
Nov 12, 2025
Merged

chore: extract system+user volume config transformers, test#12196
talos-bot merged 1 commit intosiderolabs:mainfrom
laurazard:user-volumeconfig-internal-refactors

Conversation

@laurazard
Copy link
Copy Markdown
Contributor

@laurazard laurazard commented Nov 11, 2025 •
edited
Loading

Pull Request

What? (description)

Needs #12122.

Move internal/app/machined/pkg/controllers/block/ system_volumes.go+user_volumes.go (and extras) to internal/app/machined/pkg/controllers/block/internal. Adds unit tests.

Why? (reasoning)

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@github-project-automation github-project-automation bot moved this to To Do in Planning Nov 11, 2025
@laurazard laurazard mentioned this pull request Nov 11, 2025
Merged
7 tasks
@laurazard laurazard force-pushed the user-volumeconfig-internal-refactors branch 6 times, most recently from 65e3d02 to daddda7 Compare November 11, 2025 12:31
@laurazard laurazard self-assigned this Nov 11, 2025
@laurazard laurazard force-pushed the user-volumeconfig-internal-refactors branch from daddda7 to ed7a136 Compare November 11, 2025 12:40
@laurazard laurazard marked this pull request as ready for review November 11, 2025 12:40
@talos-bot talos-bot moved this from To Do to In Review in Planning Nov 11, 2025
@laurazard laurazard force-pushed the user-volumeconfig-internal-refactors branch 3 times, most recently from a0d54e3 to 38ae542 Compare November 12, 2025 09:30
@laurazard laurazard requested a review from smira November 12, 2025 11:14
smira
smira approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@github-project-automation github-project-automation bot moved this from In Review to Approved in Planning Nov 12, 2025
@laurazard laurazard force-pushed the user-volumeconfig-internal-refactors branch from 38ae542 to 2876425 Compare November 12, 2025 12:38
@laurazard
chore: extract system+user volume config transformers, test
859194e 
Move `internal/app/machined/pkg/controllers/block/` `system_volumes.go`
+ `user_volumes.go` (and extras) to
`internal/app/machined/pkg/controllers/block/internal`. Adds plenty of
unit tests.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@laurazard laurazard force-pushed the user-volumeconfig-internal-refactors branch from 2876425 to 859194e Compare November 12, 2025 15:09
@laurazard
Copy link
Copy Markdown
Contributor Author

laurazard commented Nov 12, 2025

Rebased on top of @shanduur's changes now :')

@laurazard
Copy link
Copy Markdown
Contributor Author

laurazard commented Nov 12, 2025

/m

@talos-bot talos-bot merged commit 859194e into siderolabs:main Nov 12, 2025
103 of 104 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Planning Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smira smira smira approved these changes

Assignees

@laurazard laurazard

Labels

integration/qemu

Projects

Planning
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laurazard @smira @talos-bot