fix: validate missing apiVersion in config document decoder

CYPH4R · smira · commit c46b89807dfa · 2026-03-18T21:16:03.000+04:00
Add ErrMissingAPIVersion check in the config document decoder, parallel to the existing ErrMissingKind. Previously, a typo in the apiVersion key (e.g. 'apiVerstion') would result in a misleading 'not registered' error instead of clearly indicating the missing field. Signed-off-by: Dominik Pitz <pitzdominik@gmail.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit a728bbd)
diff --git a/pkg/machinery/config/configloader/internal/decoder/decoder.go b/pkg/machinery/config/configloader/internal/decoder/decoder.go
@@ -21,6 +21,9 @@ import (
 // ErrMissingKind indicates that the manifest is missing a kind.
 var ErrMissingKind = errors.New("missing kind")
 
+// ErrMissingAPIVersion indicates that the manifest is missing an apiVersion.
+var ErrMissingAPIVersion = errors.New("missing apiVersion")
+
 const (
 	// ManifestAPIVersionKey is the string indicating a manifest's version.
 	ManifestAPIVersionKey = "apiVersion"
@@ -176,6 +179,8 @@ func decode(manifest *yaml.Node) (target config.Document, err error) {
 		target, err = registry.New("v1alpha1", "")
 	case kind == "":
 		err = ErrMissingKind
+	case version == "":
+		err = ErrMissingAPIVersion
 	default:
 		target, err = registry.New(kind, version)
 	}
diff --git a/pkg/machinery/config/configloader/internal/decoder/decoder_test.go b/pkg/machinery/config/configloader/internal/decoder/decoder_test.go
@@ -322,7 +322,15 @@ config:
           - content: MONITOR ${upsmonHost} 1 remote pass foo
             mountPath: /usr/local/etc/nut/upsmon.conf
 `),
-			expectedErr: "error decoding document /ExtensionServiceConfig/ (line 2): \"ExtensionServiceConfig\" \"\": not registered",
+			expectedErr: "error decoding document /ExtensionServiceConfig/ (line 2): missing apiVersion",
+		},
+		{
+			name: "missing apiVersion",
+			source: []byte(`---
+kind: mock
+test: true
+`),
+			expectedErr: "error decoding document /mock/ (line 2): missing apiVersion",
 		},
 	}
 
