fix: add warnings to 802.3ad bond

shanduur · shanduur · commit bc56bdff74ee · 2026-02-05T11:36:40.000+01:00
In case some settings are missing that might be impacting the usage of 802.3ad, present a warning to users. Signed-off-by: Mateusz Urbanek <mateusz.urbanek@siderolabs.com> (cherry picked from commit 7f1147b)
diff --git a/pkg/machinery/config/types/network/bond.go b/pkg/machinery/config/types/network/bond.go
@@ -359,6 +359,8 @@ func (s *BondConfigV1Alpha1) Validate(validation.RuntimeMode, ...validation.Opti
 
 	if s.BondMode == nil {
 		errs = errors.Join(errs, errors.New("bond mode must be specified"))
+	} else if *s.BondMode == nethelpers.BondMode8023AD {
+		warnings = append(warnings, s.validateFor8023AD()...)
 	}
 
 	extraWarnings, extraErrs := s.CommonLinkConfig.Validate()
@@ -367,6 +369,26 @@ func (s *BondConfigV1Alpha1) Validate(validation.RuntimeMode, ...validation.Opti
 	return warnings, errs
 }
 
+func (s *BondConfigV1Alpha1) validateFor8023AD() []string {
+	const warn = " was not specified for 802.3ad bond"
+
+	var warnings []string
+
+	if s.BondMIIMon == nil {
+		warnings = append(warnings, "miimon"+warn)
+	}
+
+	if s.BondUpDelay == nil {
+		warnings = append(warnings, "updelay"+warn)
+	}
+
+	if s.BondDownDelay == nil {
+		warnings = append(warnings, "downdelay"+warn)
+	}
+
+	return warnings
+}
+
 // Links implements NetworkBondConfig interface.
 func (s *BondConfigV1Alpha1) Links() []string {
 	return s.BondLinks
diff --git a/pkg/machinery/config/types/network/bond_test.go b/pkg/machinery/config/types/network/bond_test.go
@@ -158,6 +158,12 @@ func TestBondValidate(t *testing.T) {
 
 				return cfg
 			},
+
+			expectedWarnings: []string{
+				"miimon was not specified for 802.3ad bond",
+				"updelay was not specified for 802.3ad bond",
+				"downdelay was not specified for 802.3ad bond",
+			},
 		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
