fix: boot with GRUB

smira · smira · commit 72fe98a06f31 · 2026-01-19T14:14:47.000+04:00
The problem is that xfs with 6.18 LTS settings is not supported
by GRUB yet. It might be supported with newly released 2.14 though.

Signed-off-by: Andrey Smirnov &lt;andrey.smirnov@siderolabs.com&gt;
diff --git a/pkg/machinery/imager/quirks/quirks.go b/pkg/machinery/imager/quirks/quirks.go
@@ -250,10 +250,9 @@ func (q Quirks) XFSMkfsConfig() string {
 	// if the version doesn't parse, we assume it's latest Talos
 	// update when we have a new LTS config
 	case version == nil:
-		return "/usr/share/xfsprogs/mkfs/lts_6.18.conf"
+		// [TODO]: lts_6.18.config doesn't work with GRUB, it doesn't recognize the xfs filesystem.
+		return "/usr/share/xfsprogs/mkfs/lts_6.12.conf"
 	// add new version once we have a new LTS config
-	case version.GTE(semver.MustParse("1.13.0")):
-		return "/usr/share/xfsprogs/mkfs/lts_6.18.conf"
 	case version.GTE(semver.MustParse("1.10.0")):
 		return "/usr/share/xfsprogs/mkfs/lts_6.12.conf"
 	case version.GTE(semver.MustParse("1.8.0")) && version.LT(semver.MustParse("1.10.0")):
diff --git a/pkg/machinery/imager/quirks/quirks_test.go b/pkg/machinery/imager/quirks/quirks_test.go
@@ -169,10 +169,10 @@ func TestXFSMkfsConfigFile(t *testing.T) {
 		},
 		{
 			version:  "1.13.0",
-			expected: "/usr/share/xfsprogs/mkfs/lts_6.18.conf",
+			expected: "/usr/share/xfsprogs/mkfs/lts_6.12.conf",
 		},
 		{
-			expected: "/usr/share/xfsprogs/mkfs/lts_6.18.conf",
+			expected: "/usr/share/xfsprogs/mkfs/lts_6.12.conf",
 		},
 	} {
 		t.Run(test.version, func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,10 @@ func TestXFSMkfsConfigFile(t *testing.T) {`
`169`	`169`	`},`
`170`	`170`	`{`
`171`	`171`	`version: "1.13.0",`
`172`		`- expected: "/usr/share/xfsprogs/mkfs/lts_6.18.conf",`
	`172`	`+ expected: "/usr/share/xfsprogs/mkfs/lts_6.12.conf",`
`173`	`173`	`},`
`174`	`174`	`{`
`175`		`- expected: "/usr/share/xfsprogs/mkfs/lts_6.18.conf",`
	`175`	`+ expected: "/usr/share/xfsprogs/mkfs/lts_6.12.conf",`
`176`	`176`	`},`
`177`	`177`	`} {`
`178`	`178`	`t.Run(test.version, func(t *testing.T) {`