Close siderolabs/go-kmsg#10: Support PRINTK_CALLER kmsg logs#11
Merged
talos-bot merged 1 commit intosiderolabs:mainfrom May 8, 2024
Merged
Close siderolabs/go-kmsg#10: Support PRINTK_CALLER kmsg logs#11talos-bot merged 1 commit intosiderolabs:mainfrom
talos-bot merged 1 commit intosiderolabs:mainfrom
Conversation
6eedfc1 to
80f1b35
Compare
smira
approved these changes
May 8, 2024
Member
smira
left a comment
There was a problem hiding this comment.
please rework commit message title to be something like
feat: support PRINTK_CALLER kmsg logs
thank you, otherwise looks good!
Contributor
Author
|
Thanks for the feedback. Changed the commit message and removed the unnecessary else block in fa57baa ! |
Member
|
@happy-dude please fix issues: https://github.com/siderolabs/go-kmsg/actions/runs/9004193958/job/24736607350?pr=11 make sure |
Contributor
Author
|
Apologies,
Should be ready with 6c4e5c8 ! Appreciate the feedback. |
Closes siderolabs#10 Add support for caller information in kmsg log entries. More examples available at siderolabs#10 (comment) Also adds tests for a log entry with a Thread caller and a Cpu caller. Further references: * https://elixir.bootlin.com/linux/v6.6.22/source/kernel/printk/printk_ringbuffer.h#L15 * https://elixir.bootlin.com/linux/v6.6.22/source/kernel/printk/printk.c#L629 Signed-off-by: Stanley Chan <pocketgamer5000@gmail.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Member
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Add support for caller information in kmsg log entries. More examples available at #10 (comment)
Also adds tests for a log entry with a Thread caller and a Cpu caller.
Further references: