Skip to content

Don't update default values when model changes#402

Merged
manuel-mauky merged 1 commit into
sialcasa:developfrom
johnp:defaultValuesFix
Jun 20, 2016
Merged

Don't update default values when model changes#402
manuel-mauky merged 1 commit into
sialcasa:developfrom
johnp:defaultValuesFix

Conversation

@johnp

@johnp johnp commented Jun 17, 2016

Copy link
Copy Markdown
Contributor

This seems wrong to me. Otoh, if this behavior is intended it should probably be documented.

@johnp

johnp commented Jun 17, 2016

Copy link
Copy Markdown
Contributor Author

fixed test

@johnp johnp closed this Jun 17, 2016
@johnp johnp reopened this Jun 17, 2016
@manuel-mauky

Copy link
Copy Markdown
Collaborator

Hi Johannes,
thanks for your PR. You are correct, this is a wrong behaviour that was introduced with #372.

@manuel-mauky manuel-mauky reopened this Jun 20, 2016
@manuel-mauky manuel-mauky added this to the 1.5.1 milestone Jun 20, 2016
@manuel-mauky manuel-mauky merged commit 8c048dc into sialcasa:develop Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants