Revert "feat(shuttle-axum) Make AxumService generic to be able to use axum::State with it (#924)"#1199
Merged
chesedo merged 1 commit intoshuttle-hq:mainfrom Sep 8, 2023
jonaro00:revert-axum-generic
Merged
Revert "feat(shuttle-axum) Make AxumService generic to be able to use axum::State with it (#924)"#1199chesedo merged 1 commit intoshuttle-hq:mainfrom jonaro00:revert-axum-generic
chesedo merged 1 commit intoshuttle-hq:mainfrom
jonaro00:revert-axum-generic
Conversation
Member
Author
|
@morlinbrot I'm curios what you think. Am I right or wrong? |
orhun
approved these changes
Sep 6, 2023
iulianbarbu
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e6ade25.
Description of change
An axum router with
<S != ()>cannot be turned into a service. IT is only implemented for<S = ()>https://docs.rs/axum/latest/axum/struct.Router.html#impl-Router%3C(),+B%3EThe generic
<S>means which state the router is missing. https://docs.rs/axum/latest/axum/routing/struct.Router.html#what-s-in-routers-meansHow has this been tested? (if applicable)
The example that was created for "verifying" #924, shuttle-hq/shuttle-examples#52, did not verify the functionality of the generic (it's a good example tho). If you try setting S to anything, your code will now compile.
Basically, #924 was never fully tested.