Improved deterministic build support #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sungam3r this should solve the errors you reported, I'll work on testing this on one of the repos you linked to |
Member
Author
|
I've recreated your issue on AspNetCore.Diagnostics.HealthChecks @sungam3r, and have confirmed that this new package fixes the issue. I'll leave this PR open for comments for a day, if there are no comments then I'll look to get a |
Contributor
|
Thanks. |
Contributor
|
4.2.1 seems work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #883, it turns out that as suspected there is a need to support building and running tests in separate steps while also using deterministic builds.
This PR adds:
DeterministicBuildHelpers/_/,/_1/etc.. This is used in theShouldMatchApprovedmethod, where an accurate resolved location is essential.dotnet testis ran on it's own, a build will be performed but it will be "within" the VSTest target, so wont run before it. In this case we set the environment variable directly, as we know the tests will run later and in the same process tree.DisableShouldlyPathMapsbuild property users can set totrueto completely disable this behaviour, just in case.