Implement ShouldBeDecoratedWith() for Type #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 8, 2020 12:52
sungam3r
reviewed
Mar 8, 2020
sungam3r
reviewed
Mar 8, 2020
src/Shouldly/ShouldlyExtensionMethods/ShouldBeDecoratedWithExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Mar 8, 2020
src/Shouldly/ShouldlyExtensionMethods/ShouldBeDecoratedWithExtensions.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
…ensions.cs Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
…ensions.cs Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
…houldly Into Decorated-With
sungam3r
reviewed
Mar 13, 2020
| [ShouldlyMethods] | ||
| public static class ShouldBeDecoratedWithExtensions | ||
| { | ||
| public static void ShouldBeDecoratedWith<T>(this Type actual) where T : class |
Contributor
There was a problem hiding this comment.
Suggested change
| public static void ShouldBeDecoratedWith<T>(this Type actual) where T : class | |
| public static void ShouldBeDecoratedWith<T>(this Type actual) where T : Attribute |
Same for other methods.
Contributor
Author
|
@sungam3r can you pls see if the comments have been addressed? |
Contributor
|
LGTM |
sungam3r
approved these changes
Mar 15, 2020
Contributor
Author
|
@sungam3r what's the process for merging PRs. Do I need to tag anyone? |
Contributor
|
I have no write access to this repo. Ask @josephwoodward to review/merge PR. |
Contributor
Author
|
@josephwoodward if you're happy with the changes, can you pls merge it? |
Contributor
|
@josephwoodward probably easiest for you to merge and resolve the conflicts? or i can resubmit a new PR with the conflicts resolved |
Contributor
|
@hrai thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves and closes #291