Fix Ubuntu build #596

jnm2 · 2019-12-01T21:10:51Z

cake-build/cake#2501 clued me in to the fact that GitVersion can be run on Ubuntu so long as you use the .NET Global tool.

One thing required the next, and it became necessary to move some of the tooling cleanup from #581 to this PR. I'll be rebasing to simplify and resolve conflicts in #581 as soon as this PR merges.

jnm2 · 2019-12-02T04:41:22Z

build.cake

+#module nuget:?package=Cake.DotNetTool.Module&version=0.4.0
+
+#tool nuget:?package=GitReleaseNotes&version=0.7.1
+#tool dotnet:?package=GitVersion.Tool&version=5.1.2


Cake adds warnings to the build output if specific versions are not used. The nice part is that it also speeds up the NuGet querying to compile on each run.

@jnm2 we actually always recommend pinning to specific versions of all tools/addins/modules, we are just becoming a little bit more vocal about it 😄

jnm2 · 2019-12-02T04:42:14Z

build.sh

-else
-    exec mono "$CAKE_EXE" $SCRIPT -verbosity=$VERBOSITY -configuration=$CONFIGURATION -target=$TARGET $DRYRUN "${SCRIPT_ARGUMENTS[@]}"
-fi
+mono "$CAKE_EXE" $SCRIPT --bootstrap


The --bootstrap call is needed if #module is used.

@jnm2 in a soon to be released version of Cake, the bootstrapping will happen automatically without the need to have this step in your bootstrapper, but for now, this is the correct approach.

jnm2 · 2019-12-02T04:42:24Z

build.ps1

 Write-Host "Running build script..."
-&$CAKE_EXE $cakeArguments
-exit $LASTEXITCODE
+Invoke-Expression "& $CAKE_EXE_INVOCATION $($cakeArguments -join " ") --bootstrap"


The --bootstrap call is needed if #module is used.

@jnm2 in a soon to be released version of Cake, the bootstrapping will happen automatically without the need to have this step in your bootstrapper, but for now, this is the correct approach.

jnm2 · 2019-12-02T04:55:03Z

src/Shouldly.Tests/Shouldly.Tests.csproj

    <LangVersion>latest</LangVersion>
    <Optimize>false</Optimize>
    <DebugType Condition=" '$(OS)' == 'Windows_NT' ">full</DebugType>
-    <RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp2.1' ">2.0.9</RuntimeFrameworkVersion>


This had to be removed because .NET Core 2.0 was not found on the Ubuntu image. (It is EOL.)

jnm2 · 2019-12-02T04:55:58Z

appveyor.yml

@@ -1,5 +1,5 @@
 image:
-  - Visual Studio 2017
+  - Visual Studio 2019


.NET Core 2.1 doesn't seem to be on the VS2017 image, so this change was necessary after removing the <RuntimeFrameworkVersion> element.

jnm2 · 2019-12-02T04:56:16Z

src/Shouldly.Tests/Shouldly.Tests.csproj

    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
    <PackageReference Include="PublicApiGenerator" Version="8.0.1" />
    <PackageReference Include="TestStack.ConventionTests" Version="3.0.1" />
-    <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />


Once the <RuntimeFrameworkVersion> element was removed, dotnet-xunit caused this error on Ubuntu:

Running .NET Core tests for framework netcoreapp2.1... A fatal error was encountered. The library 'libhostpolicy.so' required to execute the application was not found in '/home/appveyor/.nuget/packages/dotnet-xunit/2.3.1/tools/netcoreapp2.0/xunit.console.dll'.

dotnet-xunit was discontinued: https://github.com/xunit/xunit/issues/1835#issuecomment-431199286

Version 2.3.1 has no rollforward policy and can only run on .NET Core 2.0 which is EOL.

gep13 · 2019-12-02T08:02:31Z

build.cake

+#module nuget:?package=Cake.DotNetTool.Module&version=0.4.0
+
+#tool nuget:?package=GitReleaseNotes&version=0.7.1
+#tool dotnet:?package=GitVersion.Tool&version=5.1.2


@jnm2 we actually always recommend pinning to specific versions of all tools/addins/modules, we are just becoming a little bit more vocal about it 😄

gep13 · 2019-12-02T08:03:33Z

build.ps1

 Write-Host "Running build script..."
-&$CAKE_EXE $cakeArguments
-exit $LASTEXITCODE
+Invoke-Expression "& $CAKE_EXE_INVOCATION $($cakeArguments -join " ") --bootstrap"


@jnm2 in a soon to be released version of Cake, the bootstrapping will happen automatically without the need to have this step in your bootstrapper, but for now, this is the correct approach.

gep13 · 2019-12-02T08:03:49Z

build.sh

-else
-    exec mono "$CAKE_EXE" $SCRIPT -verbosity=$VERBOSITY -configuration=$CONFIGURATION -target=$TARGET $DRYRUN "${SCRIPT_ARGUMENTS[@]}"
-fi
+mono "$CAKE_EXE" $SCRIPT --bootstrap


@jnm2 in a soon to be released version of Cake, the bootstrapping will happen automatically without the need to have this step in your bootstrapper, but for now, this is the correct approach.

josephwoodward · 2019-12-02T14:47:29Z

@jnm2 Is this good to merge?

jnm2 · 2019-12-02T14:50:28Z

@josephwoodward I think so!

@gep13 Thanks for the info!

josephwoodward · 2019-12-13T10:42:37Z

Thanks so much for this @jnm2

jnm2 · 2019-12-13T13:06:29Z

You're quite welcome!

jnm2 · 2019-12-13T14:05:57Z

@josephwoodward Could you retrigger builds on the recent PRs?

jnm2 force-pushed the fix_ubuntu_build branch 7 times, most recently from 94f9130 to 7002686 Compare December 1, 2019 22:22

jnm2 added 2 commits December 1, 2019 23:31

Use GitVersion .NET global tool to gain support for non-Windows OSs

b916e25

Update bootstrappers (build.sh didn't bootstrap Cake modules)

e0d2f09

jnm2 force-pushed the fix_ubuntu_build branch from 7002686 to b916e25 Compare December 2, 2019 04:31

Bootstrapping is missing from default bootstrappers

a2b68f5

jnm2 force-pushed the fix_ubuntu_build branch from 94315c7 to a2b68f5 Compare December 2, 2019 04:38

jnm2 commented Dec 2, 2019

View reviewed changes

jnm2 changed the title ~~[WIP] Fix Ubuntu build~~ Fix Ubuntu build Dec 2, 2019

.NET Core 2.0 is EOL

36c4429

jnm2 force-pushed the fix_ubuntu_build branch from 1672c84 to 36c4429 Compare December 2, 2019 04:47

dotnet-xunit appears to have been deprecated

94eee7c

jnm2 commented Dec 2, 2019

View reviewed changes

jnm2 marked this pull request as ready for review December 2, 2019 04:56

jnm2 mentioned this pull request Dec 2, 2019

Fix broken tests from master #589

Merged

gep13 approved these changes Dec 2, 2019

View reviewed changes

josephwoodward merged commit b981907 into shouldly:master Dec 13, 2019

jnm2 deleted the fix_ubuntu_build branch December 13, 2019 13:06

jnm2 mentioned this pull request Dec 13, 2019

Nullable reference types #581

Closed

Uh oh!

Fix Ubuntu build #596

Fix Ubuntu build #596

Uh oh!

Conversation

jnm2 commented Dec 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josephwoodward commented Dec 2, 2019

Uh oh!

jnm2 commented Dec 2, 2019

Uh oh!

josephwoodward commented Dec 13, 2019

Uh oh!

jnm2 commented Dec 13, 2019

Uh oh!

jnm2 commented Dec 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jnm2 commented Dec 1, 2019 •

edited

Loading