-
-
Notifications
You must be signed in to change notification settings - Fork 427
Refactor ShouldThrowAsync for cancellation handing and add test #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also probably solves: #471 |
|
Sorry for the late reply, thanks for this! |
|
I'll fix the merge conflict then get it out in the next release. |
|
Is there a time-frame for this to put pushed out to NuGet? The last package that I can see there was November 2018, and this was merged in to Master in June 2019. |
|
There's currently a 4.0.0 beta that doesn't introduce any major breaking changes that will include this. |
|
I've just tried testing call of function Foo and got different behaviour in test, depending on what variant I use: The output is: I've expected that It will be OperationCanceledException in all variants. It seems, that ThrowAsync still works wrong in case of canceled task. I've used latest available release version 4.0.3. |
|
@alexnnenn Worth to open new issue. This one may be lost. |
First time to contribute here.
Looking at solving: #457
Might have issues as I couldn't compile all target frameworks on my mac.