Skip to content

add generic overloads for ShouldSatisfyAllConditions #472 #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dlumpp wants to merge 3 commits into from
Closed

add generic overloads for ShouldSatisfyAllConditions #472 #498

dlumpp wants to merge 3 commits into from

Conversation

@dlumpp
Copy link
Contributor

@dlumpp dlumpp commented Apr 5, 2018

add three new generic overloads to give actions passed to ShouldSatisfyAllConditions some context as suggested in #472

added:

public static void ShouldSatisfyAllConditions<T>(this T actual, [InstantHandle] params Action<T>[] conditions)
public static void ShouldSatisfyAllConditions<T>(this T actual, string customMessage, [InstantHandle] params Action<T>[] conditions)
public static void ShouldSatisfyAllConditions<T>(this T actual, [InstantHandle] Func<string> customMessage, [InstantHandle] params Action<T>[] conditions)

@josephwoodward
Copy link
Contributor

josephwoodward commented Jan 15, 2019

Sorry it's taken so long for me to get around to merging this, thanks for the PR! I'll be getting this merged in time for Shouldly 4.0

@dperez3 dperez3 mentioned this pull request May 11, 2019
Closed
@SimonCropp SimonCropp changed the base branch from master to GenericShouldSatisfyAllConditions- July 4, 2020 08:44
@SimonCropp SimonCropp changed the base branch from GenericShouldSatisfyAllConditions- to master July 4, 2020 08:45
@SimonCropp SimonCropp mentioned this pull request Jul 4, 2020
Merged
@SimonCropp
Copy link
Contributor

SimonCropp commented Jul 4, 2020

@dlumpp thanks. manually merged here #625

@SimonCropp SimonCropp closed this Jul 4, 2020
@SimonCropp SimonCropp mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlumpp @josephwoodward @SimonCropp