-
-
Notifications
You must be signed in to change notification settings - Fork 427
Fix handling of zero tolerances #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slang25
merged 1 commit into
shouldly:master
from
martincostello:fix-zero-tolerance-false-failures
Jan 20, 2025
Merged
Fix handling of zero tolerances #1049
slang25
merged 1 commit into
shouldly:master
from
martincostello:fix-zero-tolerance-false-failures
Jan 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix assertions incorrectly failing when a tolerance of zero is used.
Member
|
Thanks @martincostello, the tolerance should be inclusive IMO, so this is bug, thanks for the fix |
slang25
approved these changes
Jan 20, 2025
This was referenced Aug 23, 2025
This was referenced Sep 1, 2025
This was referenced Sep 10, 2025
This was referenced Sep 18, 2025
This was referenced Oct 26, 2025
This was referenced Nov 21, 2025
This was referenced Dec 1, 2025
This was referenced Dec 9, 2025
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix assertions incorrectly failing when a tolerance of "zero" for the type is used.
I migrated Polly from FluentAssertions to Shouldly over the weekend and we had a test like this:
Migrating to Shouldly, I changed this to:
The test then failed despite the values being equal.
I guess the original author wanted to be explicit? This was easily resolved by just changing the assertion to
value.ShouldBe(expected).This PR fixes that behaviour by changing
<to<=forTimeSpan, as well asdecimal,double,DateTimeandDateTimeOffsetthat also have the same issue.If non-zero tolerances being equal shouldn't match, then an alternative fix could be to special-case "zero" for these cases in
Is.