Refactor fully shard runtime modules#4
Merged
shjwudp merged 1 commit intoMay 11, 2026
Merged
Conversation
d8fe051 to
77c3ae0
Compare
shjwudp
reviewed
May 11, 2026
| grad_comm_dtype: Optional[torch.dtype] = None | ||
|
|
||
|
|
||
| def build_fully_shard_mixed_precision_policy(ddp_config) -> FullyShardMixedPrecisionPolicy: |
Owner
There was a problem hiding this comment.
Could the code related to DDPConfig be placed in mcore_fsdp_adapter.py? The rewritten code should minimize dependencies on MCore as much as possible.
| # reduce-scatter output must not alias the full input buffer, otherwise the | ||
| # collective can clobber its own input and silently corrupt gradients. | ||
| if reduced_grad_shard.dtype != self.dtype: | ||
| reduced_grad_shard = reduced_grad_shard.to(self.dtype) |
Owner
There was a problem hiding this comment.
Do we need to explicitly convert the data type before performing addition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.