Skip to content

Restored temperature info for macOS#800

Merged
Lomanic merged 2 commits intoshirou:masterfrom
Girbons:feature/restore-temperature-info-macos
Dec 17, 2019
Merged

Restored temperature info for macOS#800
Lomanic merged 2 commits intoshirou:masterfrom
Girbons:feature/restore-temperature-info-macos

Conversation

@Girbons
Copy link
Copy Markdown
Contributor

@Girbons Girbons commented Dec 13, 2019

reintroduced temperature info for macOS following what was proposed in #797.

Tested on my macOS seems to work
Screenshot 2019-12-16 at 11 24 18

@Lomanic
Copy link
Copy Markdown
Collaborator

Lomanic commented Dec 15, 2019

Thanks for this great PR, I only have a hackintosh VM to test it so all values are set to 0 but they are all the same as the last GPL version from 63047d7. Could you fix these compilation warnings, seen for example when i ran the tests with go test github.com/shirou/gopsutil/host?

In file included from host/host_darwin_cgo.go:7:
host/include/smc.c:77:5: warning: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Wimplicit-function-declaration]
host/include/smc.c:77:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'
host/include/smc.c:93:7: warning: implicitly declaring library function 'strlen' with type 'unsigned long (const char *)' [-Wimplicit-function-declaration]
host/include/smc.c:93:7: note: include the header <string.h> or explicitly provide a declaration for 'strlen'
host/include/smc.c:124:3: warning: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)' [-Wimplicit-function-declaration]
host/include/smc.c:124:3: note: include the header <string.h> or explicitly provide a declaration for 'memset'
host/include/smc.c:151:3: warning: implicitly declaring library function 'memcpy' with type 'void *(void *, const void *, unsigned long)' [-Wimplicit-function-declaration]
host/include/smc.c:151:3: note: include the header <string.h> or explicitly provide a declaration for 'memcpy'

@Lomanic Lomanic merged commit 71ddd2a into shirou:master Dec 17, 2019
@Lomanic
Copy link
Copy Markdown
Collaborator

Lomanic commented Dec 17, 2019

Thanks again @Girbons

@Girbons Girbons deleted the feature/restore-temperature-info-macos branch December 18, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants