Merged
Conversation
Based the experience from Mockito project let's try the approach to perform "bintrayUpload" *before* tagging the release in GitHub. Originally we thought that tagging *before* artifact publishing is a good idea. Bad tag is easier to revert than reverting binary artifacts publish. In fact, we cannot unpublish artifacts from some repositories, such as Maven Central. In practice though, tagging almost never fails. Therefore, let's run the task that *may* fail before tagging. This way, in case of a failure, there is less manual fixing (removing tags/release notes from GH) and less confusion to our end users (no more releases on GH that don't have any artifacts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based the experience from Mockito project let's try the approach to perform "bintrayUpload" before tagging the release in GitHub.
Originally we thought that tagging before artifact publishing is a good idea. Bad tag is easier to revert than reverting binary artifacts publish. In fact, we cannot unpublish artifacts from some repositories, such as Maven Central. In practice though, tagging almost never fails. Therefore, let's run the task that may fail before tagging. This way, in case of a failure, there is less manual fixing (removing tags/release notes from GH) and less confusion to our end users (no more releases on GH that don't have any artifacts).