fix: guard leaving the entry form with a confirm#44
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements dirty guards for navigation in a KeePass database TUI application to prevent users from accidentally losing unsaved changes when navigating away from an entry. The implementation centralizes dirty state checking in a new NavigateTo method that displays a confirmation dialog when there are unsaved changes.
Changes:
- Added dirty guard logic to the navigation system with explicit opt-out mechanism
- Replaced local dirty checks with centralized navigation guards
- Introduced
RefreshCurrentView()method to re-render views without navigation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tui/app.go | Added NavigateTo with dirty guard, NavigateToWithoutDirtyGuard for explicit bypass, and RefreshCurrentView for re-rendering; introduced lastView field to track current view |
| tui/entry.go | Removed duplicate dirty guard logic for Ctrl+K navigation; replaced refresh() calls with RefreshCurrentView() |
| tui/groups.go | Updated group selection and creation to use NavigateToWithoutDirtyGuard since state changes warrant bypassing the guard; replaced navigation with RefreshCurrentView() after group deletion |
| tui/layout.go | Updated Ctrl+P and Ctrl+N handlers to use appropriate navigation methods (with/without guard) |
| test/tui_test.go | Added test to verify dirty guard triggers on navigation with unsaved changes; removed unrelated password assertion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change introduces dirty guards to navigation, forcing consumers to explicitly opt out wherever required. Cases where the no-guard checks were expected because we wanted to issue a re-render have been replaced with an explicit rerender method.
d51c245 to
161567c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces dirty guards to navigation, forcing consumers to
explicitly opt out wherever required. Cases where the no-guard checks
were expected because we wanted to issue a re-render have been replaced
with an explicit rerender method.
Closes #43