fix: notify when attempting a modification while in read-only mode#42
Merged
fix: notify when attempting a modification while in read-only mode#42
Conversation
This change makes field changes behave like all the other modifications to the entries while in read-only mode. That is, notify the user instead of only preempting the change.
There was a problem hiding this comment.
Pull request overview
This PR aims to improve UX in read-only mode by notifying the user when they attempt blocked modifications (including typing into fields), aligning field-change behavior with other read-only-blocked actions.
Changes:
- Standardized several read-only notification messages from “Could not …” to “Cannot …”.
- Added a read-only notification when rune input is received (intended to cover field edits).
- Extended E2E tests to assert a notification is shown when typing in read-only mode.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tui/layout.go | Updates read-only create message and adds a global read-only “update” notification on rune input. |
| tui/groups.go | Adjusts read-only delete notification wording. |
| tui/entry.go | Adjusts read-only save/delete notification wording. |
| tui/entries.go | Adjusts read-only delete notification wording. |
| test/tui_test.go | Adds read-only typing coverage and reworks assertions around notifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes field changes behave like all the other modifications
to the entries while in read-only mode. That is, notify the user instead
of only preempting the change.
Closes #29