fix: return missing reference error in copy command#41
Merged
Conversation
copy command
copy commandcopy command
There was a problem hiding this comment.
Pull request overview
Adds automated end-to-end coverage for the keydex binary (TUI + CLI) and adjusts the codebase/docs to support running these tests in CI alongside unit tests.
Changes:
- Introduces extensive TUI e2e tests using a
tcellsimulation screen and CLI integration tests against the built binary. - Refactors TUI startup to allow dependency injection of a screen for tests (
Setup,SetScreen) and tweaks layout behavior (Resizeon content set). - Updates CLI behavior (copy reference validation, logging) and developer tooling/docs (Makefile targets, CONTRIBUTING smoke tests).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tui/layout.go | Triggers a resize after content changes to keep layout consistent in TUI/e2e runs. |
| tui/app.go | Enables screen injection + test setup path for simulation-based TUI e2e tests. |
| test/tui_test.go | Adds simulation-driven TUI e2e suite covering core flows (create/edit/delete/read-only/list). |
| test/cli_test.go | Adds CLI integration tests that execute the built binary against a fixture database. |
| cmd/list.go | Adjusts logging around database/key selection during list command execution. |
| cmd/copy.go | Adjusts logging and adds explicit “missing reference” handling for copy command. |
| Makefile | Makes make test build the binary first; adds clean target. |
| LICENSE | Updates copyright year. |
| CONTRIBUTING.md | Replaces long manual test checklist with focused smoke/side-effect checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces richer e2e coverage of the keydex binary, with a battery of automated e2e TUI tests and CLI tests.
They are run along with unit tests because the whole suite takes ~5s.
Tests with side effects (i.e., file I/O and clipboard) are still to be done manually, and the list of manual tests has been reduced to a battery of smoke tests.
This closes #32