tests: Remove duplicate fake client method

stephenfin · stephenfin · commit 2f524851f328 · 2025-05-20T18:17:35.000+01:00
Signed-off-by: Stephen Finucane &lt;stephenfin@redhat.com&gt;
diff --git a/pagination/testing/linked_test.go b/pagination/testing/linked_test.go
@@ -9,6 +9,7 @@ import (
 
 	"github.com/gophercloud/gophercloud/v2/pagination"
 	th "github.com/gophercloud/gophercloud/v2/testhelper"
+	"github.com/gophercloud/gophercloud/v2/testhelper/client"
 )
 
 // LinkedPager sample and test cases.
@@ -48,7 +49,7 @@ func createLinked() pagination.Pager {
 		fmt.Fprint(w, `{ "ints": [7, 8, 9], "links": { "next": null } }`)
 	})
 
-	client := createClient()
+	client := client.ServiceClient()
 
 	createPage := func(r pagination.PageResult) pagination.Page {
 		return LinkedPageResult{pagination.LinkedPageBase{PageResult: r}}
diff --git a/pagination/testing/marker_test.go b/pagination/testing/marker_test.go
@@ -9,6 +9,7 @@ import (
 
 	"github.com/gophercloud/gophercloud/v2/pagination"
 	th "github.com/gophercloud/gophercloud/v2/testhelper"
+	"github.com/gophercloud/gophercloud/v2/testhelper/client"
 )
 
 // MarkerPager sample and test cases.
@@ -58,7 +59,7 @@ func createMarkerPaged(t *testing.T) pagination.Pager {
 		}
 	})
 
-	client := createClient()
+	client := client.ServiceClient()
 
 	createPage := func(r pagination.PageResult) pagination.Page {
 		p := MarkerPageResult{pagination.MarkerPageBase{PageResult: r}}
diff --git a/pagination/testing/pagination_test.go b/pagination/testing/pagination_test.go
diff --git a/pagination/testing/single_test.go b/pagination/testing/single_test.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/gophercloud/gophercloud/v2/pagination"
 	th "github.com/gophercloud/gophercloud/v2/testhelper"
+	"github.com/gophercloud/gophercloud/v2/testhelper/client"
 )
 
 // SinglePage sample and test cases.
@@ -34,7 +35,7 @@ func ExtractSingleInts(r pagination.Page) ([]int, error) {
 
 func setupSinglePaged() pagination.Pager {
 	th.SetupHTTP()
-	client := createClient()
+	client := client.ServiceClient()
 
 	th.Mux.HandleFunc("/only", func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Add("Content-Type", "application/json")

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`
`10`	`10`	`"github.com/gophercloud/gophercloud/v2/pagination"`
`11`	`11`	`th "github.com/gophercloud/gophercloud/v2/testhelper"`
	`12`	`+ "github.com/gophercloud/gophercloud/v2/testhelper/client"`
`12`	`13`	`)`
`13`	`14`
`14`	`15`	`// MarkerPager sample and test cases.`
`@@ -58,7 +59,7 @@ func createMarkerPaged(t *testing.T) pagination.Pager {`
`58`	`59`	`}`
`59`	`60`	`})`
`60`	`61`
`61`		`- client := createClient()`
	`62`	`+ client := client.ServiceClient()`
`62`	`63`
`63`	`64`	`createPage := func(r pagination.PageResult) pagination.Page {`
`64`	`65`	`p := MarkerPageResult{pagination.MarkerPageBase{PageResult: r}}`