GNOME terminal not always present when using "Open in Shell" for first time #344
Description
Describe the bug
Can't open repository folder in terminal on Deepin DE (also fails on Deepin OS distro)
Version & OS
Github Desktop Version: 2.5.4-linux1
OS: Arch Linux x64 - kernel version: 5.8.8-arch1-1
Steps to reproduce the behavior
- Open a local repository
- Go to Repository menu
- Click on 'Open in
GNOME(?) Terminal' menu item (no GNOME installed) - Bang! Error message shown
Expected behavior
System's default Virtual Terminal Emulator (Deepin Terminal, in my case) started on repository folder
Actual behavior
This message:
Screenshots
Compared to referenced issue #167 , Deepin Terminal finally appears in shell menu
Logs
2020-09-16T17:11:11.064Z - info: [ui] Background fetch for 10 repositories took 1.321sec
2020-09-16T17:17:31.709Z - info: [ui] [AppStore] loading 10 repositories from store
2020-09-16T17:17:31.709Z - info: [ui] [AppStore] found account: jmejia32 (Javier Mejía Estrada)
2020-09-16T17:17:32.253Z - info: [ui] launching: 2.5.4-linux1 (Linux 5.8.8-arch1-1)
2020-09-16T17:17:32.254Z - info: [ui] execPath: '/opt/github-desktop/github-desktop'
2020-09-16T17:19:21.527Z - info: [ui] [AppStore] loading 9 repositories from store
2020-09-16T17:19:21.527Z - info: [ui] [AppStore] found account: jmejia32 (Javier Mejía Estrada)
2020-09-16T17:19:22.070Z - info: [ui] launching: 2.5.4-linux1 (Linux 5.8.8-arch1-1)
2020-09-16T17:19:22.071Z - info: [ui] execPath: '/opt/github-desktop/github-desktop'